fix Issue 20730 - [REG 2.091] __traits(compiles) fails if any ungagged errors occurred in compilation#11023
Merged
dlang-bot merged 1 commit intodlang:stablefrom Apr 12, 2020
Merged
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#11023" |
thewilsonator
approved these changes
Apr 12, 2020
Member
Author
|
@thewilsonator - I just remembered last minute that maybe should be targetting stable. ;-) |
rainers
reviewed
Apr 12, 2020
rainers
reviewed
Apr 12, 2020
Member
|
removing automerge for now, I think this just shuffles semantic analysis order, but doesn't solve the actual issue. |
…d errors occurred in compilation When running semantic on __traits(compiles), errors are gagged, so the saved errors count is global.gaggedErrors, and not global.errors. So the condition always evaluated as true if any real errors occured during compilation, and every subsequent __traits(compiles) errors too, whether it is valid syntax or not.
Member
Author
|
@rainers check again. |
Member
Thanks, I get it now. Using |
rainers
approved these changes
Apr 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running semantic on __traits(compiles), errors are gagged, so the saved errors count is global.gaggedErrors, and not global.errors.
So the condition always evaluated as true if any real errors occured during compilation, and every subsequent __traits(compiles) errors too, whether it is valid syntax or not.