Skip to content

Comments

Port runnable/paranoia.sh to D#11178

Merged
dlang-bot merged 2 commits intodlang:masterfrom
MoonlightSentinel:paranio
Jun 2, 2020
Merged

Port runnable/paranoia.sh to D#11178
dlang-bot merged 2 commits intodlang:masterfrom
MoonlightSentinel:paranio

Conversation

@MoonlightSentinel
Copy link
Contributor

Separate PR because this requires a slight extension to d_do_test.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11178"

{
string[] oss = split(result[1 .. close], " ");
if (oss.canFind(envData.os))
if (oss.canFind!(o => o.skipOver(envData.os) && (o.empty || o == envData.model)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain a bit more why the normal find doesn't work and your reasoning for the new condition. Ideally as a comment in the script so that it's clear to future people reading the source code. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an explanation and rationale for ${OS}${MODEL}.

The current implementation just felt less wasteful than
oss.canFind(envData.os, envData.os ~ envData.model)

@thewilsonator
Copy link
Contributor

Is this good to go?

@MoonlightSentinel
Copy link
Contributor Author

Yes

@dlang-bot dlang-bot merged commit 4d3af05 into dlang:master Jun 2, 2020
@MoonlightSentinel MoonlightSentinel deleted the paranio branch January 2, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants