Port runnable/paranoia.sh to D#11178
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11178" |
| { | ||
| string[] oss = split(result[1 .. close], " "); | ||
| if (oss.canFind(envData.os)) | ||
| if (oss.canFind!(o => o.skipOver(envData.os) && (o.empty || o == envData.model))) |
There was a problem hiding this comment.
Could you please explain a bit more why the normal find doesn't work and your reasoning for the new condition. Ideally as a comment in the script so that it's clear to future people reading the source code. Thanks!
There was a problem hiding this comment.
Added an explanation and rationale for ${OS}${MODEL}.
The current implementation just felt less wasteful than
oss.canFind(envData.os, envData.os ~ envData.model)
efacf04 to
cf17b10
Compare
cf17b10 to
2354095
Compare
2354095 to
4d2ba80
Compare
|
Is this good to go? |
|
Yes |
Separate PR because this requires a slight extension to
d_do_test.