Skip to content

Comments

Fix incorrect .editorconfig comment#11192

Merged
dlang-bot merged 1 commit intodlang:masterfrom
kubo39:fix-editorconfig
May 28, 2020
Merged

Fix incorrect .editorconfig comment#11192
dlang-bot merged 1 commit intodlang:masterfrom
kubo39:fix-editorconfig

Conversation

@kubo39
Copy link
Contributor

@kubo39 kubo39 commented May 28, 2020

The comment is outdated since #8656 was merged.
(FYI: kinke taught me by this review comment).

The comment is outdated since dlang#8656 was
merged.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11192"

@Geod24 Geod24 added Merge:auto-merge Review:Trivial typos, formatting, comments labels May 28, 2020
@dlang-bot dlang-bot merged commit ffcf873 into dlang:master May 28, 2020
@kubo39 kubo39 deleted the fix-editorconfig branch May 29, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants