Get rid of obsolete __ArrayEq lowering#11212
Conversation
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11212" |
|
This looks good, is it still draft? |
|
I thought it'd be a trivial little change, but it turned out more involved and probably need some more analysis. I might also look into the different-floating-points => |
Comparing arrays of different element types for equality is (also) handled by the (more recent) __equals() lowering, rendering __ArrayEq obsolete and enabling to get rid of duplicated functionality in druntime too, see: https://github.com/dlang/druntime/blob/master/src/core/internal/array/equality.d
It might be about time to put creal on a proper deprecation path. |
... #7640 |
As rendered obsolete by dlang/dmd#11212.
As rendered obsolete by dlang/dmd#11212.
|
This PR apparently fixed https://issues.dlang.org/show_bug.cgi?id=21012 along the way. |
As rendered obsolete by dlang/dmd#11212.
Checking arrays of different element types for equality is handled by the (more recent)
__equals()lowering, rendering__ArrayEqobsolete and enabling to get rid of duplicated functionality in druntime, see: https://github.com/dlang/druntime/blob/9ce4a36f1f4edb73683775e5824272da9e27dccc/src/core/internal/array/equality.d#L56-L65