Skip to content

Fix a few minor discrepancies in C++ headers#11218

Merged
dlang-bot merged 2 commits intodlang:masterfrom
ibuclaw:syncheaders
Jun 4, 2020
Merged

Fix a few minor discrepancies in C++ headers#11218
dlang-bot merged 2 commits intodlang:masterfrom
ibuclaw:syncheaders

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jun 4, 2020

Noticed when doing a sync of various API changes from D->C++.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11218"

@Geod24
Copy link
Member

Geod24 commented Jun 4, 2020

/media/disk1/braddr/sandbox/at-client/pull-4072458-Linux_64_64/src/dmd/src/src/dmd/mtype.h:341:5: error: ‘TypeMixin’ does not name a type

@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 4, 2020

/media/disk1/braddr/sandbox/at-client/pull-4072458-Linux_64_64/src/dmd/src/src/dmd/mtype.h:341:5: error: ‘TypeMixin’ does not name a type

That means no one has added it to the Visitor class either then...

@ibuclaw ibuclaw requested a review from RazvanN7 as a code owner June 4, 2020 12:44
@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 4, 2020

@Geod24 ping.

@dlang-bot dlang-bot merged commit aa61a05 into dlang:master Jun 4, 2020
@ibuclaw ibuclaw deleted the syncheaders branch June 4, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants