Move the implementation of -preview=in from parser to semantic#11422
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 17, 2020
Merged
Move the implementation of -preview=in from parser to semantic#11422dlang-bot merged 1 commit intodlang:masterfrom
-preview=in from parser to semantic#11422dlang-bot merged 1 commit intodlang:masterfrom
Conversation
As noted in the original PR, implementing `-preview=in` in the parser breaks the header generation. This moves the change to semantic, fixing the header generation. However, a persistent problem is that the user will still see `foo(scope const(T))` instead of `foo(in T)` in error messages, due to the way the type is altered. This require a deeper refactoring to fix and will be done in a later PR.
Contributor
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11422" |
thewilsonator
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the long run, I restarted my efforts to make
ina first class citizen ( see #11000 ) and there's a lot of fixes required to make this work sanely.