Use .NOTPARALLEL in posix.mak instead of lockfiles in build.d#11515
Use .NOTPARALLEL in posix.mak instead of lockfiles in build.d#11515dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
A few observations:
Maybe it's an issue within the local C library used by |
3ad9d4f to
f884d88
Compare
|
[Not ready for review, just curious if Azure doesn't pick up Draft PRs] |
f884d88 to
891ed5f
Compare
891ed5f to
20b2b5c
Compare
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11515" |
00fcb82 to
cc7a03b
Compare
cc7a03b to
fa997b0
Compare
|
Just commenting based on your commits:
|
Sorry, should've clarified that I hijacked this PR to check for the segfault when building
Maybe, didn't test that yet. |
|
Not sure why the auto-tester refuses to test this PR ... |
Typically there are either many other recently opened PRs or PRs with "auto-merge" which can't be merged due to other failures.
Typically it's a PR being stuck in the auto-merge queue. |
eb1e0fe to
c9e4718
Compare
.NOTPARALLEL in posix.mak instead of lockfiles in build.d
.NOTPARALLEL in posix.mak instead of lockfiles in build.d .NOTPARALLEL in posix.mak instead of lockfiles in build.d
.NOTPARALLEL in posix.mak instead of lockfiles in build.d|
Now using |
Geod24
left a comment
There was a problem hiding this comment.
On a related note, having the parallelization of the test-suite fixed on OSX would be great. Also, this needs a rebase.
They achieve the same behaviour as `posix.mak` simply forwards to build.d. This is a workaround for https://issues.dlang.org/show_bug.cgi?id=20999 which seems to be caused by some local library based on these observations: - the failure is restricted to the macair host, no failures on D-Autotester.local - the failure happens upon the second invocation of build.d - removing `--called-from-make` makes the errror disappear. This switch enables a lockfile (`generated/build.lock`) which ensures that mutliple instances of build.d are run mutually exclusive (this was required during the `make` -> build.d transition but is obsolete now)
c9e4718 to
7029acc
Compare
|
Rebased. |
They achieve the same behaviour as
posix.maksimply forwards tobuild.d.This is a workaround for https://issues.dlang.org/show_bug.cgi?id=20999
which seems to be caused by some local library based on these observations:
on D-Autotester.local
build.d--called-from-makemakes the errror disappear.This switch enables a lockfile (
generated/build.lock) which ensuresthat mutliple instances of build.d are run mutually exclusive (this
was required during the
make->build.dtransition but is obsolete now)