Skip to content

does master pass the test suite?#11524

Closed
WalterBright wants to merge 1 commit intodlang:masterfrom
WalterBright:TestingMaster
Closed

does master pass the test suite?#11524
WalterBright wants to merge 1 commit intodlang:masterfrom
WalterBright:TestingMaster

Conversation

@WalterBright
Copy link
Copy Markdown
Member

This is to see if the random bugs when running the test suite are in the test suite rather than in the code base. Here's the current list of bugs in the test suite:

https://issues.dlang.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&keywords=TestSuite%2C%20&keywords_type=allwords&list_id=232615&query_format=advanced

I've had to re-create this several times now. Do not pull it.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11524"

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

MoonlightSentinel commented Aug 7, 2020

Again, not a bug in the test suite but current master ... dmd segfaults without output once compiling with -O. Seems like the optimizer segfaults with -lowmem or triggers some GC related bug.

@WalterBright
Copy link
Copy Markdown
Member Author

How did master wind up getting pulled if it fails every time to pass the test suite?

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

Insufficient tests which do not reliably trigger the Heisenbug. That bad but not a bug in the test suite.

Sometimes caused by merging PRs based upon trust ...

@WalterBright
Copy link
Copy Markdown
Member Author

It's also the damned run.d failing, so none of the tests can be run.

It could also be a druntime issue, or a phobos issue.

@WalterBright
Copy link
Copy Markdown
Member Author

Seriously, folks, the test harness should NOT BE BUILT WITH THE COMPILER UNDER TEST. Sorry I'm shouting again, but nobody seems to feel this is of any importance.

@Geod24
Copy link
Copy Markdown
Member

Geod24 commented Aug 7, 2020

Seriously, folks, the test harness should NOT BE BUILT WITH THE COMPILER UNDER TEST. Sorry I'm shouting again, but nobody seems to feel this is of any importance.

I don't think anyone is arguing it should. @wilzbach raised a PR for it: #11519

@WalterBright
Copy link
Copy Markdown
Member Author

Working again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants