dtoh: do not write exact compiler version in silent mode#11680
Merged
dlang-bot merged 1 commit intodlang:masterfrom Sep 3, 2020
Merged
dtoh: do not write exact compiler version in silent mode#11680dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11680" |
MoonlightSentinel
approved these changes
Sep 3, 2020
Member
|
why does this break anything? |
Contributor
|
Contributor
Author
|
(+ also when people eventually start to generate headers like we do with |
Contributor
|
This change should probably be listed in the existing changelog entry. |
Contributor
Author
Nah. This is implementation detail. |
Contributor
|
Fair enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exact compiler version breaks
AUTO_UPDATEand also will require unnecessary updates tofrontend.h.See also: #11679 (comment)