Skip to content

[stable] Fix another frontend C++ interop regression#11784

Merged
thewilsonator merged 1 commit intodlang:stablefrom
kinke:fixcpp
Sep 23, 2020
Merged

[stable] Fix another frontend C++ interop regression#11784
thewilsonator merged 1 commit intodlang:stablefrom
kinke:fixcpp

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Sep 22, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11784"

@kinke
Copy link
Contributor Author

kinke commented Sep 22, 2020

This seems to uncover a dtoh shortcoming, not accounting for extern(D) functions potentially affecting the vtable layout. Pinging @ibuclaw.

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ibuclaw
Copy link
Member

ibuclaw commented Sep 23, 2020

This seems to uncover a dtoh shortcoming, not accounting for extern(D) functions potentially affecting the vtable layout. Pinging @ibuclaw.

A bugzilla issue would be good.

@thewilsonator
Copy link
Contributor

fatal: Remote branch v2.094.0 not found in upstream origin

Same here, looks like a stable problem?

@kinke
Copy link
Contributor Author

kinke commented Sep 23, 2020

A bugzilla issue would be good.

https://issues.dlang.org/show_bug.cgi?id=21271

@kinke
Copy link
Contributor Author

kinke commented Sep 23, 2020

Same here, looks like a stable problem?

Apparently a problem for the dlang.org repo in the short period where stable's VERSION is already set to the upcoming tag...

@thewilsonator thewilsonator merged commit 05c9d0f into dlang:stable Sep 23, 2020
@kinke kinke deleted the fixcpp branch September 23, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants