Skip to content

dmd.builtin: Match any submodule of the std.math package#12420

Merged
thewilsonator merged 1 commit intodlang:masterfrom
ibuclaw:ctfe/stdmath_package
Apr 10, 2021
Merged

dmd.builtin: Match any submodule of the std.math package#12420
thewilsonator merged 1 commit intodlang:masterfrom
ibuclaw:ctfe/stdmath_package

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Apr 10, 2021

Unblocks dlang/phobos#7942 and dlang/phobos#7943 (though haven't tested the latter locally).

We are already matching std.math.* in the back-end, the fix just wasn't applied to the front-end as well.

dmd/src/dmd/toir.d

Lines 512 to 521 in e658df1

// ... except std.math package and core.stdc.stdarg.va_start.
if (md.packages.length == 2)
{
// Matches any module in std.math.*
if (md.packages[1] == Id.math && id1 == Id.std)
{
goto Lstdmath;
}
goto Lva_start;
}

@ibuclaw ibuclaw added Review:Blocking Other Work review and pulling should be a priority Review:Easy Review labels Apr 10, 2021
@ibuclaw ibuclaw requested a review from thewilsonator April 10, 2021 16:48
@ibuclaw ibuclaw requested a review from WalterBright as a code owner April 10, 2021 16:49
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12420"

@ibuclaw ibuclaw requested a review from RazvanN7 April 10, 2021 16:52
@thewilsonator thewilsonator merged commit 81249b5 into dlang:master Apr 10, 2021
@ibuclaw ibuclaw deleted the ctfe/stdmath_package branch April 11, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Blocking Other Work review and pulling should be a priority Review:Easy Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants