change SR to ScopeRef, make it global#12819
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12819" |
| * Returns: | ||
| * value from enum ScopeRef | ||
| */ | ||
| ScopeRef buildScopeRef(bool returnByRef, StorageClass stc) pure nothrow @nogc @safe |
There was a problem hiding this comment.
If you're not planning to use them in subsequent PRs, I suggest you make these declarations private.
|
The C++ headers need to be updated. |
|
Don't be alarmed! Attempting to clear the backlog - for context, all Azure/x86/OMF pipelines are broken and will hang for 2 hours, meanwhile possible fix will otherwise have to wait 6 hours or more until we know the result. Will re-open this in about 15-30 minutes. |
|
Good! Thanks for your help with this. |
If you have any tips for fixing optlink, they would be welcome. See #12823 (comment) |
Instead of repeating this logic (badly) move buildSR to being a global so other code can use it: