Skip to content

Comments

change SR to ScopeRef, make it global#12819

Merged
thewilsonator merged 1 commit intodlang:masterfrom
WalterBright:enumSR
Jul 7, 2021
Merged

change SR to ScopeRef, make it global#12819
thewilsonator merged 1 commit intodlang:masterfrom
WalterBright:enumSR

Conversation

@WalterBright
Copy link
Member

Instead of repeating this logic (badly) move buildSR to being a global so other code can use it:

  1. rename SR to ScopeRef to make it easily searchable
  2. rename buildSR to buildScopeRef
  3. move ScopeRef and buildScopeRef to module scope

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12819"

* Returns:
* value from enum ScopeRef
*/
ScopeRef buildScopeRef(bool returnByRef, StorageClass stc) pure nothrow @nogc @safe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're not planning to use them in subsequent PRs, I suggest you make these declarations private.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I am!

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jul 6, 2021

The C++ headers need to be updated.

@ibuclaw
Copy link
Member

ibuclaw commented Jul 6, 2021

Don't be alarmed! Attempting to clear the backlog - for context, all Azure/x86/OMF pipelines are broken and will hang for 2 hours, meanwhile possible fix will otherwise have to wait 6 hours or more until we know the result. Will re-open this in about 15-30 minutes.

@ibuclaw ibuclaw closed this Jul 6, 2021
@ibuclaw ibuclaw reopened this Jul 6, 2021
@ibuclaw ibuclaw closed this Jul 6, 2021
@ibuclaw ibuclaw reopened this Jul 6, 2021
@ibuclaw ibuclaw closed this Jul 6, 2021
@ibuclaw ibuclaw reopened this Jul 6, 2021
@WalterBright
Copy link
Member Author

Good! Thanks for your help with this.

@ibuclaw
Copy link
Member

ibuclaw commented Jul 7, 2021

Good! Thanks for your help with this.

If you have any tips for fixing optlink, they would be welcome. See #12823 (comment)

@thewilsonator thewilsonator merged commit e6c596a into dlang:master Jul 7, 2021
@WalterBright WalterBright deleted the enumSR branch July 27, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants