Skip to content

Comments

Lower all non-memcmp-able array equality comparisons to __equals template#13331

Draft
kinke wants to merge 4 commits intodlang:masterfrom
kinke:__equals
Draft

Lower all non-memcmp-able array equality comparisons to __equals template#13331
kinke wants to merge 4 commits intodlang:masterfrom
kinke:__equals

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Nov 21, 2021

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13331"

@kinke
Copy link
Contributor Author

kinke commented Nov 22, 2021

The CTFE failures of runnable/sdtor.d are caused by https://issues.dlang.org/show_bug.cgi?id=22536.

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jan 5, 2022

@kinke Is there anything else besides Issue 22536 blocking this PR? I see that compilation of phobos is failing with:

std/array.d(1418): Error: incompatible types for array comparison: `C[5]` and `C[5]`

@kinke
Copy link
Contributor Author

kinke commented Jan 7, 2022

@RazvanN7: Sorry, I don't remember, but I guess then it was just the first hurdle before investigating library unittest failures. Thanks for tackling the CTFE issue btw, much appreciated.

@kinke
Copy link
Contributor Author

kinke commented Mar 25, 2022

Needs a CTFE fix (#13496?) and then looking into the then-appearing test regressions like that C[5] above (possibly requiring some __equals adaptations in druntime).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants