Lower all non-memcmp-able array equality comparisons to __equals template#13331
Lower all non-memcmp-able array equality comparisons to __equals template#13331kinke wants to merge 4 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13331" |
Thus never calling `_adEq2` anymore.
|
The CTFE failures of |
|
@kinke Is there anything else besides Issue 22536 blocking this PR? I see that compilation of phobos is failing with: |
|
@RazvanN7: Sorry, I don't remember, but I guess then it was just the first hurdle before investigating library unittest failures. Thanks for tackling the CTFE issue btw, much appreciated. |
|
Needs a CTFE fix (#13496?) and then looking into the then-appearing test regressions like that |
No description provided.