Skip to content

Gag errors mentioning _d_array{,set}ctor#13476

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
teodutu:gag-_d_arrayctor-errors
Jan 3, 2022
Merged

Gag errors mentioning _d_array{,set}ctor#13476
RazvanN7 merged 1 commit intodlang:masterfrom
teodutu:gag-_d_arrayctor-errors

Conversation

@teodutu
Copy link
Copy Markdown
Member

@teodutu teodutu commented Dec 30, 2021

While working on #13116, I made the mistake of letting nothrow and purity errors leak the internal lowering to _d_array{,set}ctor. This is bad practice and is confusing to the user. This PR rectifies that mistake.

Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13476"

@RazvanN7 RazvanN7 merged commit e5e0b5f into dlang:master Jan 3, 2022
@ibuclaw
Copy link
Copy Markdown
Member

ibuclaw commented Jan 8, 2022

This caused a regression https://issues.dlang.org/show_bug.cgi?id=22659

@teodutu teodutu deleted the gag-_d_arrayctor-errors branch May 21, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants