remove the markdown related switches#14050
Conversation
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14050" |
5e22812 to
ad60f46
Compare
| static immutable reverts = [ | ||
| Feature("dip25", "useDIP25", "revert DIP25 changes https://github.com/dlang/DIPs/blob/master/DIPs/archive/DIP25.md"), | ||
| Feature("intpromote", "fix16997", "revert integral promotions for unary + - ~ operators"), | ||
| Feature("markdown", "markdown", "disable Markdown replacements in Ddoc"), |
There was a problem hiding this comment.
Should reverts be deprecated first?
There was a problem hiding this comment.
Dunno. Part of this PR was to figure out what, if anything, breaks. Buildkite is green so probably not much.
If this were a switch that affected codegen I'd be much more cautious, but this affects documentation only, and it's been enabled by default for several years now.
| "give deprecation messages about all usages of complex or imaginary types", true, true), | ||
| Feature("tls", "vtls", | ||
| "list all variables going into thread local storage"), | ||
| Feature("vmarkdown", "vmarkdown", |
There was a problem hiding this comment.
Should transitions be deprecated first?
|
Hmm, I wonder if this comment is still accurate? |
I assume the order would have been:
1 and 2 are interchangeable (and in-fact if 2 is merged first, then 1+3 can be done together). |
It appears to already have been removed. |
|
Added changelog entry. @WalterBright seems to be in favour of this: https://forum.dlang.org/post/t4mhhc$1blq$1@digitalmars.com |
RazvanN7
left a comment
There was a problem hiding this comment.
I think this is fine. I find it hard to imagine that anyone goes through the pain of using -revert=markdown
This has been the default for a couple of years now.
This has been enabled by default for a couple of years now.
Might also need a spec PR, e: there doesn't seen to be any need for this. The spec only mentions the features.
https://forum.dlang.org/post/bcwupfeuaghvjzyunbng@forum.dlang.org