Skip to content

remove the markdown related switches#14050

Merged
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:md
May 4, 2022
Merged

remove the markdown related switches#14050
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:md

Conversation

@thewilsonator
Copy link
Contributor

@thewilsonator thewilsonator commented May 1, 2022

This has been enabled by default for a couple of years now.

Might also need a spec PR, e: there doesn't seen to be any need for this. The spec only mentions the features.

https://forum.dlang.org/post/bcwupfeuaghvjzyunbng@forum.dlang.org

@thewilsonator thewilsonator added Review:Needs Approval Review:Needs Changelog A changelog entry needs to be added to /changelog labels May 1, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14050"

@thewilsonator thewilsonator force-pushed the md branch 6 times, most recently from 5e22812 to ad60f46 Compare May 1, 2022 08:38
static immutable reverts = [
Feature("dip25", "useDIP25", "revert DIP25 changes https://github.com/dlang/DIPs/blob/master/DIPs/archive/DIP25.md"),
Feature("intpromote", "fix16997", "revert integral promotions for unary + - ~ operators"),
Feature("markdown", "markdown", "disable Markdown replacements in Ddoc"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should reverts be deprecated first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno. Part of this PR was to figure out what, if anything, breaks. Buildkite is green so probably not much.
If this were a switch that affected codegen I'd be much more cautious, but this affects documentation only, and it's been enabled by default for several years now.

"give deprecation messages about all usages of complex or imaginary types", true, true),
Feature("tls", "vtls",
"list all variables going into thread local storage"),
Feature("vmarkdown", "vmarkdown",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should transitions be deprecated first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@thewilsonator
Copy link
Contributor Author

Hmm, I wonder if this comment is still accurate?

@ibuclaw
Copy link
Member

ibuclaw commented May 1, 2022

Hmm, I wonder if this comment is still accurate?

I assume the order would have been:

  1. Undocument the preview in dmd
  2. Remove the preview from the phobos makefiles
  3. Deprecate the preview.

1 and 2 are interchangeable (and in-fact if 2 is merged first, then 1+3 can be done together).

@thewilsonator
Copy link
Contributor Author

Remove the preview from the phobos makefiles

It appears to already have been removed.

@thewilsonator thewilsonator removed the Review:Needs Changelog A changelog entry needs to be added to /changelog label May 2, 2022
@thewilsonator
Copy link
Contributor Author

Added changelog entry.

@WalterBright seems to be in favour of this: https://forum.dlang.org/post/t4mhhc$1blq$1@digitalmars.com

Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I find it hard to imagine that anyone goes through the pain of using -revert=markdown

This has been the default for a couple of years now.
@thewilsonator thewilsonator deleted the md branch May 4, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants