Issue 9309 - Regression (2.061): -O -release generates wrong code#1474
Merged
WalterBright merged 1 commit intodlang:masterfrom Jan 13, 2013
Merged
Issue 9309 - Regression (2.061): -O -release generates wrong code#1474WalterBright merged 1 commit intodlang:masterfrom
WalterBright merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
How can it be strongly pure if it has mutable state accessible through the context pointer? |
Contributor
Author
|
Ah..., right. The root problem is in |
In current, all nested functions should be weak purity at most.
Contributor
Author
|
Updated. |
WalterBright
added a commit
that referenced
this pull request
Jan 13, 2013
Issue 9309 - Regression (2.061): -O -release generates wrong code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=9309
By merging pull #1110, escapeShellArgument!allocator is marked as PUREstrong.
But it is a nested function, and its call may have a side effect through
its hidden context pointer. So glue layer cannot remove its call.