Skip to content

Comments

Fix 23679 - off-by-one error for static array size limit#14867

Merged
RazvanN7 merged 1 commit intodlang:stablefrom
dkorpel:static-limit
Feb 8, 2023
Merged

Fix 23679 - off-by-one error for static array size limit#14867
RazvanN7 merged 1 commit intodlang:stablefrom
dkorpel:static-limit

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Feb 7, 2023

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 7, 2023

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23679 minor off-by-one error for static array size limit

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14867"

@ibuclaw
Copy link
Member

ibuclaw commented Feb 7, 2023

Seems fine for stable

@dkorpel dkorpel changed the base branch from master to stable February 7, 2023 22:48
@RazvanN7 RazvanN7 merged commit f08dd66 into dlang:stable Feb 8, 2023
@ibuclaw ibuclaw mentioned this pull request Feb 13, 2023
@@ -0,0 +1,3 @@
// DISABLED: win32
// https://issues.dlang.org/show_bug.cgi?id=23679
ubyte [0x7fff_ffffU] arr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you do this to me? :-)

@dkorpel dkorpel deleted the static-limit branch March 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants