Refactoring/improvement of issue 8408, and additionally fixing Issue 8998#1519
Merged
WalterBright merged 4 commits intodlang:masterfrom Mar 4, 2013
Merged
Refactoring/improvement of issue 8408, and additionally fixing Issue 8998#1519WalterBright merged 4 commits intodlang:masterfrom
WalterBright merged 4 commits intodlang:masterfrom
Conversation
- Revert "Merge pull request dlang#1418 from 9rnsr/fix9230" This reverts commit c42d35b, reversing changes made to 9f2d9ea. - Revert "Merge pull request dlang#1110 from 9rnsr/fix8408" This reverts commit b6a8093, reversing changes made to 3b06132.
…mutable By fixing issue 7769 (relax inout rule), we cannot assume a function with inout parameters as PUREstrong, because the return type may not have any inout indirections.
WalterBright
added a commit
that referenced
this pull request
Mar 4, 2013
Refactoring/improvement of issue 8408, and additionally fixing Issue 8998
Member
|
This pull request introduced a regression: |
Contributor
|
This pull request introduced a regression: |
Member
|
This PR is a fine example of why we do not allow multiple issues mangled together into one PR anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially, there is no relation between PUREstrong and the isolation of returned value.
I had misunderstood about that, and mis-implemented it in pull #1110 for issue 8408.
So this also is a refactoring change of #1110.
Additional fix:
Issue 8998 - 'inout pure' returns immutable, which in reality is mutable
By fixing issue 7769 (relax inout rule), we cannot assume a function with inout parameters as PUREstrong,
because the return type may not have any inout indirections.
Requires: #1512