Skip to content

Comments

Fix Issue 24065 - __traits(getTargetInfo) causes a segfault when pass…#15494

Merged
RazvanN7 merged 1 commit intodlang:stablefrom
RazvanN7:Issue24065
Aug 3, 2023
Merged

Fix Issue 24065 - __traits(getTargetInfo) causes a segfault when pass…#15494
RazvanN7 merged 1 commit intodlang:stablefrom
RazvanN7:Issue24065

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Aug 3, 2023

…ed a non value

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 3, 2023

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24065 critical __traits(getTargetInfo) causes a segfault when passed a non value

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15494"

@RazvanN7 RazvanN7 changed the base branch from master to stable August 3, 2023 09:38
@RazvanN7 RazvanN7 force-pushed the Issue24065 branch 2 times, most recently from a1c81fa to 9b84712 Compare August 3, 2023 09:40
@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Aug 3, 2023

I'm pretty sure the phobos buildkite failure is unrelated to this PR.

@RazvanN7 RazvanN7 merged commit 91fd0bd into dlang:stable Aug 3, 2023
@ibuclaw ibuclaw mentioned this pull request Aug 15, 2023
maxhaton pushed a commit that referenced this pull request Aug 15, 2023
This was referenced Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants