Fix Issue 24109 - [REG2.103] 'need this' when invoking outer method from inner method#15577
Merged
RazvanN7 merged 1 commit intodlang:stablefrom Sep 7, 2023
Merged
Fix Issue 24109 - [REG2.103] 'need this' when invoking outer method from inner method#15577RazvanN7 merged 1 commit intodlang:stablefrom
RazvanN7 merged 1 commit intodlang:stablefrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#15577" |
a019339 to
81f2fce
Compare
Contributor
|
Thanks, seems to make sense to me, but I'm not really familiar with this stuff and how the logic looked like before your PR introducing that |
PetarKirov
approved these changes
Sep 6, 2023
81f2fce to
2faf01b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slip up on my side when implementing the
haveSameThisfunction. It needs to check the case for inheriting classes last because the check on line 1218 used to eagerly returnfalsebefore the nested check had a chance to returntrue.cc @kinke @WalterBright