Skip to content

Fix Issue 24109 - [REG2.103] 'need this' when invoking outer method from inner method#15577

Merged
RazvanN7 merged 1 commit intodlang:stablefrom
RazvanN7:Issue_24109
Sep 7, 2023
Merged

Fix Issue 24109 - [REG2.103] 'need this' when invoking outer method from inner method#15577
RazvanN7 merged 1 commit intodlang:stablefrom
RazvanN7:Issue_24109

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Sep 5, 2023

A slip up on my side when implementing the haveSameThis function. It needs to check the case for inheriting classes last because the check on line 1218 used to eagerly return false before the nested check had a chance to return true.

cc @kinke @WalterBright

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 5, 2023

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24109 regression [REG2.103] 'need this' when invoking outer method from inner method

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15577"

@RazvanN7 RazvanN7 changed the base branch from master to stable September 5, 2023 14:11
@kinke
Copy link
Contributor

kinke commented Sep 5, 2023

Thanks, seems to make sense to me, but I'm not really familiar with this stuff and how the logic looked like before your PR introducing that haveSameThis.

@RazvanN7 RazvanN7 merged commit a6c48b8 into dlang:stable Sep 7, 2023
@ibuclaw ibuclaw mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants