Rename Event.set() to Event.setIfInitialized()

[denizzzka]

Proposed to rename Event.set() to Event.setIfInitialized() to better reflect behavior of this method.

Yes, it really drives me crazy when setting just doesn’t work because event isn't initialized.

Previously I already tried to do something with it: dlang/druntime#3273

[dlang-bot]

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15800"

[adamdruppe]

Doesn't wait require it to be initialized too?

edit: indeed it does, wait just returns false immediately if it has not been initialized, regardless of if it has been set. same as how set does nothing if it has been uninitialized. so why is set different than wait?

[denizzzka]

@adamdruppe

so why is set different than wait?

During debug I comed across set() behaviour misnaming. Then I renamed it and fixed my code and wait() worked well without my attention.

I can rename wait() by the same way. Into Event.waitIfInitialized()?