Kill off OMF support

[rikkimax]

This is being discussed at BeerConf that it is time to go.

DMC is dead (that I remember being said by @WalterBright quite a while back).

So this removes the switch.

see also #13110 for the deprecation of this switch

[dlang-bot]

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16422"

[thewilsonator]

Will also need to kill off the CI: .azure-pipelines/windows.sh (some hits for "omf") is a start

[rikkimax]

Nic has been extremely keen to see OMF removed today, he has been doing investigative work to point out to me what needs changing to rip out the ability for people to use it.

[rikkimax]

CI is green!

Oh, and @LightBender says he wants to take you out for some after-funeral drinks if you're up for it!

[dkorpel]

As long as we keep the code generation logic, perhaps this could stay as an undocumented switch?

[thewilsonator]

The idea is to kill off the rest of it once this pulled in stages.

[rikkimax]

We still have to deal with the installer so a release can happen.

Cleaning the rest of the OMF support can wait, it's going to be a bit to untangle I expect.

[dkorpel]

This got approval from Walter

[ibuclaw]

This caused a regression.

Building Druntime 32omf
Entering dir: clones\dmd\druntime
Running: mingw32-make -j4 MODEL=32omf "DMD=C:\Users\vagrant\clones/dmd/generated/windows/release/32/dmd.exe" ENABLE_RELEASE=1 LATEST=2.109.0-beta.1
Using make SHELL "C:/Program Files/Git/usr/bin/bash.exe", should be bash.
C:\Users\vagrant\clones/dmd/generated/windows/release/32/dmd.exe -c -conf= -Isrc -Iimport -w -de -preview=dip1000 -preview=fieldwise -m32omf   -preview=dtorfields -O -release -inline  -I. -P=-I. src/core/stdc/errno.c -of../generated/windows/release/32omf/errno_c.obj
Error: unrecognized switch '-m32omf'
       run `dmd` to print the compiler manual
       run `dmd -man` to open browser on manual
mingw32-make: *** [Makefile:391: ../generated/windows/release/32omf/errno_c.obj] Error 1

[ibuclaw]

Dub also was forgotten.

https://github.com/dlang/dub/blob/ae08003a9e886d524e172cb65270b9414f750a35/source/dub/compilers/dmd.d#L139-L158

[ibuclaw]

Druntime appears forgotten.

https://github.com/dlang/dmd/blob/master/druntime/Makefile#L378

https://github.com/dlang/dmd/tree/master/druntime/def

[ibuclaw]

And likely phobos too.

https://github.com/dlang/phobos/blob/master/Makefile#L199

[rikkimax]

Dub, druntine, and Phobos like the internals can be cleaned up. The installer however I thought Nic was on that. Is that the source of the error you posted?

…

On Fri, 10 May 2024, 05:20 Iain Buclaw, ***@***.***> wrote: And likely phobos too. https://github.com/dlang/phobos/blob/master/Makefile#L199 — Reply to this email directly, view it on GitHub <#16422 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHSL42UQVOH27KKQJYO4HDZBOV6NAVCNFSM6AAAAABG5OUNJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGA4DINRTGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ibuclaw]

Dub, druntine, and Phobos like the internals can be cleaned up. The installer however I thought Nic was on that. Is that the source of the error you posted?

There's been no activity for over 2 weeks on the installer repo.

The sequencing of this seems backwards though. First drop it from the toolchain, then remove it from the compiler.