Skip to content

Rename gdb test case file such that it starts by "gdb" like the other…#16458

Merged
thewilsonator merged 1 commit intodlang:stablefrom
JohanEngelen:rename_gdbfile
May 8, 2024
Merged

Rename gdb test case file such that it starts by "gdb" like the other…#16458
thewilsonator merged 1 commit intodlang:stablefrom
JohanEngelen:rename_gdbfile

Conversation

@JohanEngelen
Copy link
Contributor

… gdb tests. (this enables disabling the test when gdb is not available on the test system)

Used in LDC's testsuite: https://github.com/ldc-developers/ldc/blob/40ad5f7583fe90a85fd675bfc0cfc287d565c94a/tests/dmd/tools/d_do_test.d#L1702-L1709

… gdb tests. (this enables disabling the test when gdb is not available on the test system)
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16458"

@thewilsonator thewilsonator merged commit 0f395e8 into dlang:stable May 8, 2024
@JohanEngelen JohanEngelen deleted the rename_gdbfile branch May 9, 2024 02:20
This was referenced May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants