Skip to content

Fix https://issues.dlang.org/show_bug.cgi?id=24546 for musl libc#16507

Merged
thewilsonator merged 1 commit intodlang:stablefrom
JohanEngelen:importc__ss
May 19, 2024
Merged

Fix https://issues.dlang.org/show_bug.cgi?id=24546 for musl libc#16507
thewilsonator merged 1 commit intodlang:stablefrom
JohanEngelen:importc__ss

Conversation

@JohanEngelen
Copy link
Contributor

No description provided.

@JohanEngelen JohanEngelen requested a review from ibuclaw as a code owner May 17, 2024 13:14
@dlang-bot
Copy link
Contributor

dlang-bot commented May 17, 2024

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24546 major importC musl setjmp.h failure

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16507"

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the commit message so the bot picks it up

@JohanEngelen
Copy link
Contributor Author

CI seems to be stuck

@thewilsonator thewilsonator merged commit cc66e60 into dlang:stable May 19, 2024
@JohanEngelen JohanEngelen deleted the importc__ss branch May 19, 2024 11:34
@ibuclaw ibuclaw mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants