Fix bugzilla 24680 - [dip1000] final auto class method infers scope b…#16751
Fix bugzilla 24680 - [dip1000] final auto class method infers scope b…#16751dkorpel merged 2 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16751" |
compiler/src/dmd/func.d
Outdated
| bool scopeInprocess; /// infer `return` and `scope` for parameters | ||
| bool inlineScanned; /// function has been scanned for inline possibilities | ||
| bool inferScope; /// infer 'scope' for parameters | ||
| bool dummy; /// unused |
There was a problem hiding this comment.
If you wonder 'Why not just remove this?', you're in for a treat. Follow up PR coming soon.
There was a problem hiding this comment.
Or maybe not if older compilers are affected?
There was a problem hiding this comment.
Between versions, there's no expectation of binary compatibility of AST nodes right?
dkorpel
force-pushed
the
escape-class-final
branch
from
c64c27c to
ba01f81
Compare
|
Ping @RazvanN7 |
dkorpel
force-pushed
the
escape-class-final
branch
from
ba01f81 to
936155f
Compare
dlang#16751) * Fix bugzilla 24680 - [dip1000] final auto class method infers scope but no return * Remove dummy variable
4 participants
…ut no return
Likely for historical reasons, it's possible to enable
scopeinference but disablereturninference, which breaks escape.d in the case of the bug report. Unify them underscopeInprocessto be consistent withnogcInprocessetc., and to disambiguate it from the functioninferScope(VarDeclaration).