Skip to content

Improve dmd.common.bitfields to allow non-bool types#16754

Closed
dkorpel wants to merge 2 commits intodlang:masterfrom
dkorpel:bitfields-non-bool
Closed

Improve dmd.common.bitfields to allow non-bool types#16754
dkorpel wants to merge 2 commits intodlang:masterfrom
dkorpel:bitfields-non-bool

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 25, 2024

For #16753

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16754"

@dkorpel dkorpel marked this pull request as ready for review July 25, 2024 15:36
@dkorpel
Copy link
Contributor Author

dkorpel commented Jul 25, 2024

I had to make some concessions to make it work with bootstrap compilers, so the visibility logic (allowing private bitfields) is gone now.

@dkorpel
Copy link
Contributor Author

dkorpel commented Jul 30, 2024

Merged through #16753

@dkorpel dkorpel closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants