Skip to content

Comments

Remove 'samples' folder, move them to undeaD#20665

Merged
thewilsonator merged 1 commit intodlang:masterfrom
dkorpel:remove-samples
Jan 11, 2025
Merged

Remove 'samples' folder, move them to undeaD#20665
thewilsonator merged 1 commit intodlang:masterfrom
dkorpel:remove-samples

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 8, 2025

The folder is hard to discover, and the code samples are really old, and unidiomatic D. I don't think anyone will miss them, but I could be wrong (I might ask around in the newsgroup).

I suggest moving them to https://github.com/dlang/undeaD, I'll open a PR there if this PR gets accepted. There's also a link in std.socket to update.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20665"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will wait a bit for other's opinions

@dkorpel dkorpel marked this pull request as ready for review January 8, 2025 23:54
@thewilsonator thewilsonator added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 9, 2025
@thewilsonator thewilsonator merged commit 646dc29 into dlang:master Jan 11, 2025
38 checks passed
@dkorpel dkorpel deleted the remove-samples branch January 11, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:72h no objection -> merge The PR will be merged if there are no objections raised.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants