Skip to content

Comments

Improve foreach AA error messages & add tests#21472

Merged
thewilsonator merged 2 commits intodlang:masterfrom
ntrel:aa-foreach-errors
Jun 23, 2025
Merged

Improve foreach AA error messages & add tests#21472
thewilsonator merged 2 commits intodlang:masterfrom
ntrel:aa-foreach-errors

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Jun 23, 2025

Split out of #21463.

Show parameter name and ref-ness.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21472"

@ntrel ntrel force-pushed the aa-foreach-errors branch from 5a3a994 to 7675c6e Compare June 23, 2025 14:58
@ntrel
Copy link
Contributor Author

ntrel commented Jun 23, 2025

2 error messages changed after rebasing with #21469, not sure how to fix so I've left the new messages in for now.

@ntrel ntrel force-pushed the aa-foreach-errors branch from 89ad6d0 to 7675c6e Compare June 23, 2025 16:40
@thewilsonator thewilsonator merged commit cbbca2b into dlang:master Jun 23, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants