druntime, musl: Remove unused __USE_FILE_OFFSET64 bindings#21639
druntime, musl: Remove unused __USE_FILE_OFFSET64 bindings#21639dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21639" |
| void* dli_saddr; | ||
| } | ||
| } | ||
| else version (CRuntime_Musl) |
There was a problem hiding this comment.
This version block already exists at line 192.
As pointed out in dlang#21249, Musl doesn't implement *64 versions of these functions because off_t is always 64 bits. However there are aliases defined if `_USE_LARGEFILE64_SOURCE` is true.
ibuclaw
force-pushed
the
musl_largefile64
branch
from
5bd5d97 to
f86a7ea
Compare
|
Overlooked sys.mman, removed that mess of static conditions. |
the-horo
left a comment
the-horo
left a comment
There was a problem hiding this comment.
This fixes the linking errors that one used to get on musl based on
dmd/druntime/src/core/sys/posix/config.d
Line 91 in 6b25c6b
true or false. Tested on x86_64 and x86 musl with both boolean values.
To fully fix 32-bit arches #21249 is still needed as, currently, time64 musl functions are called with time32 structs which can lead to stack corruption and other such runtime errors.
4 participants
As pointed out in #21249, Musl doesn't implement *64 versions of these functions because off_t is always 64 bits. However there are aliases defined if
_USE_LARGEFILE64_SOURCEis true.