Skip to content

Comments

[stable] Use memcmp for more array comparisons again#21647

Merged
thewilsonator merged 1 commit intodlang:stablefrom
kinke:use_memcmp_for_more_array_comparisons
Aug 4, 2025
Merged

[stable] Use memcmp for more array comparisons again#21647
thewilsonator merged 1 commit intodlang:stablefrom
kinke:use_memcmp_for_more_array_comparisons

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Aug 4, 2025

As the new compiler logic introduced in #21513 was more simplistic than the previous (templated) implementation in druntime. It e.g. didn't handle comparisons of multi-dimensional static arrays, e.g., byte[3][3], breaking an LDC-specific codegen test.

As the new compiler logic introduced in dlang#21513 was more simplistic than
the previous (templated) implementation in druntime. It e.g. didn't
handle comparisons of multi-dimensional static arrays, e.g., `byte[3][3]`,
breaking an LDC-specific codegen test.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#21647"

kinke added a commit to ldc-developers/ldc that referenced this pull request Aug 4, 2025
@kinke
Copy link
Contributor Author

kinke commented Aug 4, 2025

No idea how to test this easily with a non-codegen test. :/

@kinke kinke marked this pull request as ready for review August 4, 2025 13:21
@thewilsonator thewilsonator merged commit 52a8213 into dlang:stable Aug 4, 2025
76 checks passed
@kinke kinke deleted the use_memcmp_for_more_array_comparisons branch August 5, 2025 06:28
@dkorpel dkorpel mentioned this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants