Skip to content

Comments

CI: fix building with dmd versions 2.089 to 2.093#22017

Merged
thewilsonator merged 1 commit intodlang:masterfrom
rainers:ci_shadow_var
Oct 24, 2025
Merged

CI: fix building with dmd versions 2.089 to 2.093#22017
thewilsonator merged 1 commit intodlang:masterfrom
rainers:ci_shadow_var

Conversation

@rainers
Copy link
Member

@rainers rainers commented Oct 23, 2025

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22017"

@thewilsonator
Copy link
Contributor

cc @limepoutine @kubo39

@kubo39
Copy link
Contributor

kubo39 commented Oct 23, 2025

Oh, did it break something?

@thewilsonator
Copy link
Contributor

Yes:


[RUN] objdump -W /home/runner/work/dmd/dmd/compiler/test/test_results/dshell/dwarf/immutableVoid > /home/runner/work/dmd/dmd/compiler/test/test_results/dshell/dwarf/immutableVoid.objdump

/usr/bin/objdump: Error: No location lists in .debug_info section!
/usr/bin/objdump: Warning: There are 152 unused bytes at the end of section .debug_loc

@kubo39
Copy link
Contributor

kubo39 commented Oct 24, 2025

revert looks fine, I wonder why locale has an effect..

@limepoutine
Copy link
Contributor

The core issue is missing types in DWARF dump.

fix22469: Couln't find `DW_AT_name        : long` in the DWARF dump info.
fix22469: Couln't find `DW_AT_name        : ulong` in the DWARF dump info.

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take into account #22019 and remove the second commit

@rainers
Copy link
Member Author

rainers commented Oct 24, 2025

Second commit removed, it was just a guess at what might have been causing the failures. Thanks for fixing them @limepoutine .

@rikkimax
Copy link
Contributor

Looks like the only thing failed was a timeout. It is unfortunate that OSX14 only has 3 cores and everything else has 4 and I can't get 15 in.

@rainers
Copy link
Member Author

rainers commented Oct 24, 2025

Looks like the only thing failed was a timeout. It is unfortunate that OSX14 only has 3 cores and everything else has 4 and I can't get 15 in.

I suspect the issue here is that a phobos test spuriously fails on more platforms than previously assumed, see dlang/phobos#10876. We should disable that unconditionally.

@thewilsonator thewilsonator merged commit 83a802f into dlang:master Oct 24, 2025
54 of 55 checks passed
@thewilsonator
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants