Skip to content

Comments

fix Issue 11239 - [REG2.064beta] ctRegex causes link errors with -debug since Pull2550#2661

Merged
andralex merged 2 commits intodlang:masterfrom
WalterBright:fix11239
Oct 27, 2013
Merged

fix Issue 11239 - [REG2.064beta] ctRegex causes link errors with -debug since Pull2550#2661
andralex merged 2 commits intodlang:masterfrom
WalterBright:fix11239

Conversation

@WalterBright
Copy link
Member

@denis-sh
Copy link
Contributor

It's a workaround, not a fix. In the case we really have to disable symbol discarding for debug mode in FuncDeclaration::toObjFile a clear reason should be mentioned.

src/glue.c Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one-liner comment // workaround for Bugzilla 11239

@denis-sh
Copy link
Contributor

Also, as we still have another regression Issues 11114, why disabling only in debug mode?

@andralex
Copy link
Member

@WalterBright please rebase. Also, I'm also not sure about the debug vs. release behavior - we may introduce our users to some quite confusing distinction.

@WalterBright
Copy link
Member Author

Last time I tried the "Use the command line" instructions, it borked up my forked master, which I then had to reset. Is there a better way?

@mihails-strasuns
Copy link

Is there a better way?

Yes, finally learning git.

andralex added a commit that referenced this pull request Oct 27, 2013
fix Issue 11239 - [REG2.064beta] ctRegex causes link errors with -debug since Pull2550
@andralex andralex merged commit acc0cb0 into dlang:master Oct 27, 2013
andralex added a commit that referenced this pull request Oct 27, 2013
fix Issue 11239 - [REG2.064beta] ctRegex causes link errors with -debug since Pull2550
@WalterBright WalterBright deleted the fix11239 branch October 27, 2013 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants