[REG2.064a] Issue 11251 - Not able to link (Previous Definition Different)#2685
Merged
WalterBright merged 1 commit intodlang:masterfrom Oct 20, 2013
Merged
[REG2.064a] Issue 11251 - Not able to link (Previous Definition Different)#2685WalterBright merged 1 commit intodlang:masterfrom
WalterBright merged 1 commit intodlang:masterfrom
Conversation
By dlang#2540 , implicitly defined C main has been moved to __entrypoint module. But, the codegen generates ModuleInfo symbol for the module. And vibe.d has its own main function in library. Then, compiling uer progam with vibe.d library will cause the conflict of two ModuleInfo symbols of __entrypoint module. Due to avoid ModuleInfo symbol generation for __entrypoint, I added a special case in Module::genobjfile function. But, I'm not sure that the change won't cause any other problems...
WalterBright
added a commit
that referenced
this pull request
Oct 20, 2013
[REG2.064a] Issue 11251 - Not able to link (Previous Definition Different)
WalterBright
added a commit
that referenced
this pull request
Oct 20, 2013
[REG2.064a] Issue 11251 - Not able to link (Previous Definition Different)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=11251
By #2540 , implicitly defined C
mainhas been moved to__entrypointmodule. But, the codegen generates ModuleInfo symbol for the module. And vibe.d has its own main function in library. Then, compiling uer progam with vibe.d library will cause the conflict of two ModuleInfo symbols of__entrypointmodule.Due to avoid ModuleInfo symbol generation for
__entrypoint, I added a special case inModule::genobjfilefunction. But, I'm not sure that the change won't cause any other problems...