[REG2.064] Issue 11614 - Error: this for _expand_field_0 needs to be type Tuple not type Foo#2897
Merged
MartinNowak merged 1 commit intodlang:masterfrom Nov 30, 2013
Merged
Conversation
src/expression.c
Outdated
Member
There was a problem hiding this comment.
A brief comment about checkRightThis would be nice here.
Contributor
Author
There was a problem hiding this comment.
Added comment. Thanks.
Contributor
Author
There was a problem hiding this comment.
Sorry I forgot to push the updated commit. Pushed.
…ple not type Foo
Even if a variable has no valid context, it would be either:
1. a part of compile time evaluated expression, which is used as unreal context.
enum x = Type.fieldvar.sizeof;
// It's legitimate expression so fieldvar is not evaluated
// in runtime.
2. or an invalid field access without valid 'this', in runtime evaluated expression.
int y = Type.fieldvar;
// It's invalid expression so fieldvar access has no valid 'this'.
For the case #2, it will be an error by `checkRightThis` later. Therefore `getRightThis` should not make it an error.
Member
|
Auto-merge toggled on |
Member
There was a problem hiding this comment.
I hope that error propagation will make these kind of flags and the gagging superfluous at some point.
MartinNowak
added a commit
that referenced
this pull request
Nov 30, 2013
[REG2.064] Issue 11614 - Error: this for _expand_field_0 needs to be type Tuple not type Foo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://d.puremagic.com/issues/show_bug.cgi?id=11614
Even if a variable has no valid context, it would be either:
enum x = Type.fieldvar.sizeof;
// It's legitimate expression so fieldvar is not evaluated
// in runtime.
int y = Type.fieldvar;
// It's invalid expression so fieldvar access has no valid 'this'.
For the case #2, it will be an error by
checkRightThislater. ThereforegetRightThisshould not make it an error.