[REG2.058] Issue 11078 - Diagnostic for wrong RHS in property assign of a property group should improve#3014
Merged
WalterBright merged 1 commit intodlang:masterfrom Dec 23, 2013
Merged
Conversation
…operty group should improve
There was a problem hiding this comment.
This diagnostic is still wrong. It should reference the setter, meaning it should say:
Error: function diag11078.S1.value(int) is not callable using argument types (double)
That way you can tell at a glance that you're trying to pass a double to a function expecting an int.
Contributor
Author
There was a problem hiding this comment.
This message is same as 2.057, so regression issue is fixed by this change.
To show more better diagnostic, we need more work.
Member
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Dec 23, 2013
[REG2.058] Issue 11078 - Diagnostic for wrong RHS in property assign of a property group should improve
WalterBright
added a commit
that referenced
this pull request
Dec 31, 2013
[REG2.058] Issue 11078 - Diagnostic for wrong RHS in property assign of a property group should improve
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://d.puremagic.com/issues/show_bug.cgi?id=11078