fix Issue 11822 - switch causes ICE with return and other stuff#3081
Merged
9rnsr merged 1 commit intodlang:masterfrom Jan 13, 2014
Merged
fix Issue 11822 - switch causes ICE with return and other stuff#30819rnsr merged 1 commit intodlang:masterfrom
9rnsr merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Looks not bad. |
9rnsr
added a commit
that referenced
this pull request
Jan 13, 2014
fix Issue 11822 - switch causes ICE with return and other stuff
Member
Author
|
Thanks, Kenji! |
Member
|
awesomesauce |
Contributor
|
I merged this PR to fix blocker regressions of 2.065 release, but I still think my fix (#3034) is more robust way for the future. |
Contributor
|
So this is merged now. May I ask to answer Issue 11857 Comment 3? |
Contributor
Contributor
|
@WalterBright Newly reported regression 11922 has same root but your this change could not prevent the ICE. So this change is still insufficient. And my fix #3034 can resolve 11922 without any additional fix. |
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Apr 15, 2014
This reverts commit 24c1dff, excepting test cases.
Member
|
It's hard to tell, but this might have caused a bad codegen regression: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate to the fix #3034
It includes the same test cases.
https://d.puremagic.com/issues/show_bug.cgi?id=11822