fix Issue 11922 - [REG2.065a] ICE on nonexistent identifier in templated...#3094
fix Issue 11922 - [REG2.065a] ICE on nonexistent identifier in templated...#30949rnsr merged 1 commit intodlang:masterfrom
Conversation
There was a problem hiding this comment.
Your approach will continue to pollute compiler code!
There was a problem hiding this comment.
I agree with Kenji here in that this approach seems to be much more error-prone. But then, I usually only work on the semantic part for the occasional bug fix, so I'm really not the one to complain.
There was a problem hiding this comment.
I don't agree, for reasons explained in #3034
There was a problem hiding this comment.
@klickverbot I think that Walter's approach is essentially fragile, and it will need continued maintenance, like this PR. So I really don't like this change.
There was a problem hiding this comment.
@klickverbot If you have a time, could you please read our discussion in #3034?
There was a problem hiding this comment.
I've read the discussion there, otherwise I wouldn't have commented on it in the first place based on this one change. I agree with your reasoning, but as I said, I wouldn't put too much weight on my own opinion here.
There was a problem hiding this comment.
@klickverbot I understand. Thank you.
|
It's a half a line fix, guys, hardly pollution. |
|
Only once half line change is not an issue. But repeating same change again and again will be issue. |
|
@WalterBright OK, I accept this change again. But, if same bug will be found again, I'll apply my approach to stop regression repetition. |
[REG2.065a] Issue 11922 - ICE on nonexistent identifier in templated auto method
[REG2.065a] Issue 11922 - ICE on nonexistent identifier in templated auto method
This reverts commit 11f05b5, excepting test cases.
3 participants
... auto method
https://d.puremagic.com/issues/show_bug.cgi?id=11922