fix Issue 12523 - wrong type deduced for foreach ref argument#3424
Merged
9rnsr merged 1 commit intodlang:masterfrom Apr 6, 2014
Merged
fix Issue 12523 - wrong type deduced for foreach ref argument#34249rnsr merged 1 commit intodlang:masterfrom
9rnsr merged 1 commit intodlang:masterfrom
Conversation
src/statement.c
Outdated
Member
Author
There was a problem hiding this comment.
I'm not sure why setting the storage class is necessary when the var type already had all the modifiers.
- No need to change the storage class because the var type already has inferred modifiers.
Contributor
|
LGTM. |
Contributor
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Apr 6, 2014
fix Issue 12523 - wrong type deduced for foreach ref argument
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
already has inferred modifiers.
Issue 12523 – wrong foreach argument type with ref and inout