Skip to content

Comments

Issue 846 - Error 42: Symbol Undefined "<mangle_of_class_template>__arrayZ"#3552

Merged
MartinNowak merged 2 commits intodlang:masterfrom
9rnsr:fix846
May 17, 2014
Merged

Issue 846 - Error 42: Symbol Undefined "<mangle_of_class_template>__arrayZ"#3552
MartinNowak merged 2 commits intodlang:masterfrom
9rnsr:fix846

Conversation

@9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented May 17, 2014

https://issues.dlang.org/show_bug.cgi?id=846

It's separated from #2561. Even if an instantiated template is defined in non-root module, generate _array, __assert, and __unittest_fail for the module in COMDAT section.

@MartinNowak
Copy link
Member

Auto-merge toggled on

src/template.c Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update comment to

Generate these functions as they may be used
when template is instantiated in other modules.
Even if assertions or bounds checking are
disabled in this module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

9rnsr added 2 commits May 18, 2014 00:24
…>__arrayZ"

Stop using ModuleInfo for assertion and array bounds check.
Instead pass filename to `_d_assert`, `_d_unittest`, and `_d_arraybounds`.
MartinNowak added a commit that referenced this pull request May 17, 2014
Issue 846 - Error 42: Symbol Undefined "<mangle_of_class_template>__arrayZ"
@MartinNowak MartinNowak merged commit 40be370 into dlang:master May 17, 2014
@9rnsr
Copy link
Contributor Author

9rnsr commented May 17, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants