Issue 11453 - Compiling packages has a dependency on order of modules passed to the compiler#3834
Merged
2 commits merged intodlang:masterfrom Aug 3, 2014
Merged
Issue 11453 - Compiling packages has a dependency on order of modules passed to the compiler#38342 commits merged intodlang:masterfrom
2 commits merged intodlang:masterfrom
Conversation
…ules passed to the compiler
|
If the issue is not the dependency order but just the diagnostic then both the issue itself and the commit and the pull request should reflect this, otherwise you leave the reviewer confused how a diagnostic change fixes a dependency issue. |
|
I'll let it pass this time, LGTM. |
|
Auto-merge toggled on |
ghost
pushed a commit
that referenced
this pull request
Aug 3, 2014
Issue 11453 - Compiling packages has a dependency on order of modules passed to the compiler
ghost
merged commit
Contributor
Author
|
@AndrejMitrovic I assume that all reviewers have already read the corresponding bugzilla issue. And I have commented the current issue state in the issue. |
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 7, 2014
Issue 11453 - Compiling packages has a dependency on order of modules passed to the compiler
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=11453