[REG2.061] Issue 13252 - ParameterDefaultValueTuple affects other instantiations

[9rnsr]

https://issues.dlang.org/show_bug.cgi?id=13252

Expression::equals should also compare operand types.

[yebblies]

I don't like that you're changing the type before comparing. I know this is how equality works for template args, but this is supposed to be a general equals method. I assume the expressions will be cast to the correct type somewhere during template matching, so would it be possible to call equals sometime after that?

[9rnsr]

In general equals method, type should be compared. In floating point value comparison, different types mean different precisions. Please also see IntegerExp::equals, RealExp::equals, and CompexExp::equals.

And, if expressions are passed via alias or tuple parameters, there's no correct types and their types should be left as-is.

[yebblies]

I agree that types should be compared, but not that toHeadMutable should be called on them first.

[9rnsr]

but not that toHeadMutable should be called on them first.

Ah, I see. OK, I fixed it.

But, I'm not sure we should also remove toHeadMutable call from IntergerExp, RealExp, ComplexExp, and VarExp::equals. To avoid accidental existing code breaking, I'd leave them in 2.066 beta/rc phase.

[yebblies]

I think we should probably remove them, but not now is fine.

[yebblies]

Auto-merge toggled on