[REG2.066a] Issue 13259 - [ICE] 'v.result' on line 191 in file 'todt.c'

[9rnsr]

https://issues.dlang.org/show_bug.cgi?id=13259

[yebblies]

This changed an error message in another test case.

[9rnsr]

I was tried to fix the issue by moving glue-layer error to front-end, but unfortunately it seems need more work. So now I'm merely removing the wrong assert introduced by the commit 152e480.

[yebblies]

Even without the assert, it's still an ICE. Is this really the only place that assumes toDt returns non-NULL? Can you at least make it print out an error where the assert used to be?

eg print Internal error: Issue 13259 and then exit(1).

[9rnsr]

Before your visitor refactoring, toDt could return NULL. So the regression had accidentally occured by the addition of assert.

[yebblies]

Yes, but the error occurring in the glue layer is still a form of ice.

[yebblies]

Auto-merge toggled on

[9rnsr]

Yes, but the error occurring in the glue layer is still a form of ice.

Right. Essentially all errors should be detected in front-end layer.