Explicitly truncate/widen shift value in OptimizeVisitor::PowExp#4212
Merged
WalterBright merged 1 commit intodlang:masterfrom Dec 14, 2014
Merged
Explicitly truncate/widen shift value in OptimizeVisitor::PowExp#4212WalterBright merged 1 commit intodlang:masterfrom
WalterBright merged 1 commit intodlang:masterfrom
Conversation
Member
Author
|
In case it isn't obvious, this area optimises |
WalterBright
added a commit
that referenced
this pull request
Dec 14, 2014
Explicitly truncate/widen shift value in OptimizeVisitor::PowExp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain scenarios, a ^^ expression may be wider or narrower than the default tshiftcnt type (
int).Example:
As I've brought up in previous PRs, this kind of type punning in the front-end IR doesn't sit too well with strict type-checked backend, so adding in an explicit cast fixes tree verification ICE's I'm seeing in gdc-5.0.