[cleanup] Finish moving glue functions out of classes#4291
[cleanup] Finish moving glue functions out of classes#42919rnsr merged 16 commits intodlang:masterfrom
Conversation
6d59497 to
b284b37
Compare
|
Green now, I missed renaming one of the local variables that conflicted. With this, gluestub is looking very light! We have some functions to trigger typeinfo/helper/init/etc generation: Backend/object emission: Library stuff (this should probably be in frontend/driver code) Inline asm: |
|
Looks good from the LDC point of view. We have our own (currently #ifdef'd) analogues for the *Symbol methods anyway. |
|
Cool. Is there an easy way to see a diff with LDC's current frontend patches? |
|
I'll need to update my PR diff. However it will not be representative of the current situation - just what the difference should be after I get round to the many, many visitor conversions. @yebblies - Apart from what you can see when you search for |
|
I was thinking we add parser support for Visitors have solved the problem of adding methods fairly well, but we still have the problem of storing backend-dependent state. I'm thinking of |
|
It would have to be a void* if it goes in shared code. Otherwise, we could have a And in dmd-specific headers: Would that go down well? |
|
My concern is that that doesn't scale well. We'd need a different type for every ast class that needs to store data, and while it makes sense to group all the variable the backend needs together, I'm hoping there will be (many) other consumers in the future. |
|
@yebblies - I only suggest as GDC uses the same type across the board for all kinds of symbols - decls, types, etc... so it makes most logical sense for us. :) |
|
noice |
|
Sooo anyone want to merge this or should I start splitting it up? |
|
Looks good to me. |
|
Auto-merge toggled on |
|
Auto-merge toggled off |
|
Auto-merge toggled on |
|
Thanks! |
[cleanup] Finish moving glue functions out of classes
Net -216 lines.