Skip to content

Remove Phobos dependency for deprecated symbols#4613

Merged
MartinNowak merged 1 commit intodlang:masterfrom
mihails-strasuns:no-typetuple
Apr 27, 2015
Merged

Remove Phobos dependency for deprecated symbols#4613
MartinNowak merged 1 commit intodlang:masterfrom
mihails-strasuns:no-typetuple

Conversation

@mihails-strasuns
Copy link

std.typetuple is pending deprecation in Phobos. To avoid failing
the test suite, DMD should not use those symbols by that time

This PR moves simplified type-only versions of that symbols to
unittest module itself

blocks dlang/phobos#3128

@mihails-strasuns
Copy link
Author

What has happened with auto-teser? I can't see the log anymore.

@MartinNowak
Copy link
Member

What has happened with auto-teser? I can't see the log anymore.

Yeah, something is broken, I already mailed Brad.

@MartinNowak
Copy link
Member

Except for the regression tests this should be deleted. There is no use in duplicating phobos unittests in dmd.

@mihails-strasuns
Copy link
Author

With proposed slower transition which does not deprecate std.typetuple initially there is no need in this PR.

I have no idea why it needs to use Phobos but looks like it checks the behaviour of built-in variadic lists. I guess that should be replaced with something more simple, not just removed?

Majority of those tests are legacy that both duplicates Phobos
own tests and does not really test anything (only prints stuff).
@mihails-strasuns
Copy link
Author

Ok, I refocused this to simply clean up variadic.d test - it indeed looks like a rather bad chunk of legacy that duplicated Phobos tests in bad way.

@mihails-strasuns
Copy link
Author

Green. Is that what you wanted @MartinNowak ?

@mihails-strasuns
Copy link
Author

Ping. This should be trivial to merge and it blocks Phobos PR.

@MartinNowak
Copy link
Member

Auto-merge toggled on

@MartinNowak
Copy link
Member

Now you removed anything phobos related not just std.typetuple, but should be OK.

@mihails-strasuns
Copy link
Author

Now you removed anything phobos related not just std.typetuple

Yes, this was intentional. Otherwise it will strike back again if any other used Phobos symbol will get deprecated. DMD tests shouldn't rely on Phobos.

MartinNowak added a commit that referenced this pull request Apr 27, 2015
Remove Phobos dependency for deprecated symbols
@MartinNowak MartinNowak merged commit f6a14b3 into dlang:master Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants