Remove Phobos dependency for deprecated symbols#4613
Remove Phobos dependency for deprecated symbols#4613MartinNowak merged 1 commit intodlang:masterfrom mihails-strasuns:no-typetuple
Conversation
|
What has happened with auto-teser? I can't see the log anymore. |
Yeah, something is broken, I already mailed Brad. |
|
Except for the regression tests this should be deleted. There is no use in duplicating phobos unittests in dmd. |
|
With proposed slower transition which does not deprecate I have no idea why it needs to use Phobos but looks like it checks the behaviour of built-in variadic lists. I guess that should be replaced with something more simple, not just removed? |
Majority of those tests are legacy that both duplicates Phobos own tests and does not really test anything (only prints stuff).
|
Ok, I refocused this to simply clean up |
|
Green. Is that what you wanted @MartinNowak ? |
|
Ping. This should be trivial to merge and it blocks Phobos PR. |
|
Auto-merge toggled on |
|
Now you removed anything phobos related not just std.typetuple, but should be OK. |
Yes, this was intentional. Otherwise it will strike back again if any other used Phobos symbol will get deprecated. DMD tests shouldn't rely on Phobos. |
Remove Phobos dependency for deprecated symbols
std.typetuple is pending deprecation in Phobos. To avoid failing
the test suite, DMD should not use those symbols by that time
This PR moves simplified type-only versions of that symbols to
unittest module itself
blocks dlang/phobos#3128