make inclusive dtor/postblit available#4650
Merged
WalterBright merged 2 commits intodlang:masterfrom May 17, 2015
Merged
Conversation
MartinNowak
force-pushed
the
aggrDtor
branch
2 times, most recently
from
fad589c to
d7d2614
Compare
- needed for attribute correct destruction of structs and classes - same function as used by TypeInfo_Struct::xdtor
Member
Author
|
This is needed to finish RefCounted and Unique, please review ASAP. |
Member
There was a problem hiding this comment.
huh? This is the reverse of other changes further down.
Member
Author
There was a problem hiding this comment.
I know, but I can only have one Id::postblit, and for the sake of consistency I made Id::postblit like Id::ctor to mean the native mangling.
WalterBright
added a commit
that referenced
this pull request
May 17, 2015
make inclusive dtor/postblit available
Member
Author
|
Thx |
This was referenced May 17, 2015
|
std.traits.hasElaborateCopyConstructor doesn't seem to be the same as edit: i.e. is there a case where |
Member
Author
|
Yes, when one of the fields has a postblit (called |
MartinNowak
added
changelog_v2.068
Review:Needs Changelog
wilzbach
pushed a commit
to wilzbach/dmd
that referenced
this pull request
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thus reduces code size and compile time b/c TypeInfo already uses them