Add support for VS2015

[rainers]

• detect linking against VS2015 or later by checking library search paths
• add UCRT lib path for VS2015
• add "stdio_msvc14_64.obj" or "stdio_msvc12_64.obj" to link command line accordingly
• add "legacy_stdio_definitions.lib" to link command line for VS2015.

needs dlang/druntime#1341
needs dlang/druntime#1360.

[MartinNowak]

This is missing a magicport.json addition of version function detectMSVC14, but with that I can convert the PR according to #4922 (comment), and it looks like it would compile.
Maybe you just want to reset your branch to my HEAD, https://github.com/MartinNowak/dmd/tree/pr/4879.

[rainers]

Maybe you just want to reset your branch to my HEAD, https://github.com/MartinNowak/dmd/tree/pr/4879.

Will do.

I am not sure the automatic adding of an object file is the best possible solution, but I don't know a better one so far. I expected some discussion ;-)

It works for the usual cases, but there are some downsides to this approach:

• you currently cannot disable it, so you cannot link to libraries built differently using dmd.
• the detection comes with a little magic (search legacy_stdio_definitions.lib in the same folder as libcmt.lib)
• rebuilds internals of how MS link finds libraries, this might fail if another linker is used.
• some build scripts might need to be adopted if they call the linker directly (Visual D does this usually).

[MartinNowak]

At least it doesn't require any change when using dmd.

[rainers]

Maybe you just want to reset your branch to my HEAD, https://github.com/MartinNowak/dmd/tree/pr/4879.

Will do.

Done.

[rainers]

BTW: if dmd is supposed to also work without $(VCInstallDir)\vcvarsall.bat being run before, the installer will have to detect the UCRT folder and version. This is a bit ugly as it involves reading the registry and finding the newest directory in the UCRT lib/include folder.

[MartinNowak]

BTW: if dmd is supposed to also work without $(VCInstallDir)\vcvarsall.bat being run before, the installer will have to detect the UCRT folder and version. This is a bit ugly as it involves reading the registry and finding the newest directory in the UCRT lib/include folder.

Think I already did that MartinNowak/installer@45790b7 MartinNowak@8af60f3.

[MartinNowak]

Auto-merge toggled on

[yebblies]

Auto-merge toggled off

[MartinNowak]

link.d(942): Error: cannot implicitly convert expression (exists(liblegacy)) of type int to bool

[rainers]

Rebased and fixed.

[MartinNowak]

Auto-merge toggled on

[yebblies]

Still failing.

[yebblies]

Auto-merge toggled off

[MartinNowak]

LINK : fatal error LNK1181: cannot open input file 'stdio_msvc12_64.obj'

The druntime lib dir isn't in the libpath, you need to copy the objects to phobos or change the libpath.

[MartinNowak]

The druntime lib dir isn't in the libpath, you need to copy the objects to phobos or change the libpath.

The nicest solution would still be to put both obj files into the library and somehow let dmd tell the linker which one to pick.

[rainers]

The nicest solution would still be to put both obj files into the library and somehow let dmd tell the linker which one to pick.

See dlang/druntime#1360. It should be compatible with linking against older VS versions without the changes here, but I'll have to update this PR for VS2015.

[rainers]

It should be compatible with linking against older VS versions without the changes here, but I'll have to update this PR for VS2015.

Updated to work with dlang/druntime#1360 instead.

[MartinNowak]

Auto-merge toggled on