Skip to content

Turn ObjcSelector into a struct to avoid empty vtable bug#4886

Merged
WalterBright merged 1 commit intodlang:masterfrom
yebblies:objcstruct
Aug 16, 2015
Merged

Turn ObjcSelector into a struct to avoid empty vtable bug#4886
WalterBright merged 1 commit intodlang:masterfrom
yebblies:objcstruct

Conversation

@yebblies
Copy link
Contributor

@WalterBright

DMD has a bug where it emits an empty vtable for extern(C++) classes that don't have any virtual methods, causing a mismatch and crashes etc if it's ever passed across the boundary. The only classes like this currently in dmd are Lexer/Parser, which never cross the boundary.

@yebblies yebblies added the DDMD label Aug 15, 2015
@WalterBright
Copy link
Member

Doesn't pulling this require a re-do of #4884 ? This should be fixed after pulling #4884 , which should be the top priority.

@dnadlinger
Copy link
Contributor

#4884 currently does not pass the auto tester on OS X. Martin has also added a commit addressing this.

@WalterBright
Copy link
Member

I see:
 auto-tester — Pass: 10
for #4884

@yebblies
Copy link
Contributor Author

This is a prerequisite for the switch to DDMD. There are about 3 more of these. Once you pull this I will do the next one.

WalterBright added a commit that referenced this pull request Aug 16, 2015
Turn ObjcSelector into a struct to avoid empty vtable bug
@WalterBright WalterBright merged commit 20f846d into dlang:master Aug 16, 2015
@WalterBright
Copy link
Member

I don't know why, but I'll take your word for it :-)

@yebblies yebblies deleted the objcstruct branch August 16, 2015 04:00
@yebblies
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants