build against VC runtime: move ld_sprint to port.d#5010
Merged
yebblies merged 2 commits intodlang:masterfrom Sep 18, 2015
Merged
build against VC runtime: move ld_sprint to port.d#5010yebblies merged 2 commits intodlang:masterfrom
yebblies merged 2 commits intodlang:masterfrom
Conversation
rainers
force-pushed
the
port_ld_sprint
branch
from
f9c1994 to
02ee247
Compare
Member
|
May still be relevant in gdc, time will tell. I am not enthusiastic about the use of native floats that I keep seeing in these kinds of PRs. |
Member
Author
|
I have added the implementation of strtod/f from the C version that sets ERANGE for overflows and underflows. |
src/backend/strtold.c
Outdated
Member
Author
There was a problem hiding this comment.
Does anybody know what these additional bytes are supposed to do? Just padding?
rainers
force-pushed
the
port_ld_sprint
branch
from
01c2129 to
d943d25
Compare
This was referenced Sep 4, 2015
rainers
force-pushed
the
port_ld_sprint
branch
from
d943d25 to
6a33b95
Compare
Member
Author
|
rebased and conflicts resolved. |
Contributor
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Sep 18, 2015
build against VC runtime: move ld_sprint to port.d
Member
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We might also want to replace the ldouble template with constructor call for real_t so it is easier to map it to another type if the host real type doesn't match the target.
This might make longdouble.d obsolete.