fix Issue 15897 - private base class method not seen through derived class

[MartinNowak]

• properly deprecate private symbol visibility through derived classes

[dlang-bot]

Fix	Bugzilla	Description
✓	15897	private base class method not seen through derived class

[mathias-lang-sociomantic]

Looks like you need an update checkimports2a. The fix itself LGTM.

[MartinNowak]

Looks like you need an update checkimports2a. The fix itself LGTM.

I rather wait for https://github.com/dlang/dmd/pull/5651/files#diff-00b32f1ed7ba16d50e1e619c297ff277L1315 to remove the nonsense message.

[MartinNowak]

Rebased

[MartinNowak]

Fixed

[AndrejMitrovic]

Auto-merge toggled on

[9rnsr]

This change will break existing valid code, without legitimate design decision.

If someone (@WalterBright and @andralex ?) get approved the new design, it should be documented in changelog and language spec. I'll repopen the original bugzilla issue.

[AndrejMitrovic]

Hmm.. the change seemed logical to me at first. Think it needs to go through a DIP? We could revert until we agree on something.

[9rnsr]

I also think the concept talked by @MartinNowak is logical. But I think a logical behavior is not always useful.
I opened #5736 to revert this change on stable branch.

[MartinNowak]

This just turns an error into deprecation. We could discuss the change though. #5736 (comment)